fix: improve the performance of resetting the browser state by not resetting file_systems #32703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng file_systems which is not something we need to reset
ryanthemanuel
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/fix/reset-state-performance
|
| Run status |
|
| Run duration | 19m 30s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1102
|
Skipped
|
4
|
Passing
|
26731
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.4%
|
|
|---|---|
|
Untested elements
|
185
|
|
Tested elements
|
158
|
Accessibility
97.97%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
ryanthemanuel
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mschile
approved these changes
Oct 14, 2025
ryanthemanuel
commented
Oct 14, 2025
ryanthemanuel
commented
Oct 14, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Using
Storage.clearDataForOriginwas taking up to 4 seconds and the specificStorageTypethat was problematic wasfile_systemswhich is the data involved with the File Systems API. Dropping this type improves the time down to under 100ms. We are theorizing that this is not a commonly used API and will not cause state leakage between tests. If, in the future we deem it necessary to clear this out, we will need to figure out how to make this more performant.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Skip clearing
file_systemsin CDPStorage.clearDataForOriginduring browser resets to significantly improve between-spec performance; update Electron flow, unit tests, and changelog.packages/server/lib/browsers/cdp_automation.tsto callStorage.clearDataForOriginwith a targetedstorageTypeslist (cookies, indexeddb, local_storage, shader_cache, service_workers, cache_storage, interest_groups, shared_storage), omittingfile_systems.packages/server/lib/browsers/electron.ts, apply the same targetedstorageTypesduring initial browser-state clearing.packages/server/test/unit/browsers/cdp_automation_spec.tsandpackages/server/test/unit/browsers/electron_spec.jsto match the newstorageTypesset.file_systemswhen executingStorage.clearDataForOrigin.Written by Cursor Bugbot for commit 99cb56b. This will update automatically on new commits. Configure here.